How should i declare it?
attachInterrupt(digitalPinToInterrupt(Coinpin), coinInterrupt, RISING);
1 Like
itās already fix
1 Like
The compilation is successful but thers a problem the relay is always on
1 Like
Could you post your full ino file again for review?
1 Like
It would seem something is not right with the condition after your serial print. Please add in lines to print the remainingTimeMs and let us know what you see in the serial output (copy and paste is better than a screenshot). Iāve included the existing lines to set the reamingingTimeMs and check it so that you know where to put these new lines.
long remainingTimeMs = countdownEndTimeMs - nowMs;
Serial.print("remainingTimeMs: ");
Serial.println(remainingTimeMs, DEC);
if (remainingTimeMs > 0) {
Also, Iād move the statements to print the pulse to the top of your loop function, before you check if itās > 0.
void loop () {
Serial.print("Pulse: ");
Serial.println(pulse, DEC);
// If a coin has been inserted, reset the timeout
if (pulse > 0) {
1 Like
Iām sure this is going to end up being one of the longest threads on here!
The principle behind adding these serial print lines is to allow us to see what a value is before the code branches the logic based on the value. So by printing the value of pulse before we check if itās more than zero, weāll know whether the program went into that block or not. The same for the remainingTimeMs.
Another approach is to put println in each code path so that you can see where it is in the program. Itās the poor developerās debugger - because we donāt have a debugger in the Arduino IDE.
So just keep adding println statements in your code until you understand where the flow is and why itās not behaving as you expect.
2 Likes
Thank You sir for helping Iāll do my best to make this thing run
1 Like
One other thing, and this might be causing some issues, or will in future. Change the following line:
volatile int pulse = 0;
to this:
volatile byte pulse = 0;
This saves us having to disable interrupts whilst we read that value because itās a single byte.
1 Like
It must be stuck in the blocking loop then. Try replace that block with this (to include prints):
// Block the loop until a coin is inserted
while (pulse < 1) {
Serial.print("Waiting for pulse to be at least 1. Pulse: ");
Serial.println(pulse, DEC);
// Let the Arduino sleep for a bit to save battery
delay(100);
}
And please confirm youāve changed pulse to a byte from integer.
1 Like
after adding this codes this happens
// Block the loop until a coin is inserted while (pulse < 1) { Serial.print("Waiting for pulse to be at least 1. Pulse: "); Serial.println(pulse, DEC); // Let the Arduino sleep for a bit to save battery delay(100); }
this happens
C:\Users\Adrian C. Mendoza\Downloads\CZONETRIAL1\CZONETRIAL1.ino: In function 'void loop()':
CZONETRIAL1:80:21: error: a function-definition is not allowed here before '{' token
void coinInterrupt(){ pulse++;
^
CZONETRIAL1:87:1: error: expected '}' at end of input
}
^
exit status 1
a function-definition is not allowed here before '{' token
1 Like
Thereās either a missing closing brace ("}") or one too many now. When you move your cursor to the } do you see it highlight the matching opening brace?
I see the issue. You have the while in there twice.
1 Like
I already removed the other while the error about the brace has gone but my declaration of the coinInterrupt is wrong> >
> 'int coinInterrupt' redeclared as different kind of symbol
1 Like
Where id that line come from? Please remove that int coinInterrupt; line.
1 Like
And pulse doesnāt ever get to 1 when you insert a coin? If thatās the case, the interrupt might not be working. Try put a println in the interrupt method:
void coinInterrupt(){
Serial.println("coinInterrupt invoked");
pulse++;
bInserted = true;
}
1 Like
This is the coin acceptor Iāve been using, I bought this coin acceptor without a manual.
LOL isnāt that the worst. Iāve been there. Do you know what model number it has or the company name? What i normally do is just search for the schematics online. Iām sure they have an online pdf version.
I already try searching it on the internet but i didnāt find one 